Demonstrate issue with large nokogiri documents #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JonRowe I don't see any activities on this issue since 4 years. I am in favor of closing it. What do you think? |
|
@benoittgt this is a bit confusing because of the rebase, but its worth leaving open as its an issue rather than a stale PR |
JonRowe
force-pushed
the
demonstate_diff_issue_with_nokogiri
branch
from
f74f31b
to
47b9695
Compare
JonRowe
force-pushed
the
demonstate_diff_issue_with_nokogiri
branch
from
47b9695
to
f1d486b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Large nokogiri documents expand to even larger when pp'd, and this produces very complex diffs that take a long time to produce, I'm not sure if we have a solution for this but it's the source of rspec/rspec-expectations#773